Skip to content

GitLab

Commit fe914289 authored by Nitin Jadhav's avatar Nitin Jadhav
Browse files

implemented some self review comments

parent a64700f9
Pipeline #157346 passed with stages
in 4 minutes and 23 seconds
Hide whitespace changes
Inline Side-by-side
Showing with 21 additions and 316 deletions
src/app/App.jsx
View file @ fe914289
import "@visual-framework/vf-form__input/vf-form__input.css";
/* All the css files that can not be imported in index.scss */
import "@visual-framework/vf-summary/vf-summary.css";
import { Alerts } from "components/alerts/Alerts";
import { Apply } from "components/apply/Apply";
import { Partners } from "components/content/Partners";
......
src/app/App.scss
View file @ fe914289
/* common app wide styles */
/* common app-wide styles */
.multiline-ellipsis {
-webkit-box-orient: vertical;
display: -webkit-box;
......
src/component-templates/VFLoader/VFLoader.jsx
View file @ fe914289
import React from "react";
import "./VFLoader.css";
import "./VFLoader.scss";
export function VFLoader() {
return <div className="circle-loader"></div>;
......
src/components/EmblBreadcrumbs.jsx
View file @ fe914289
......@@ -3,9 +3,7 @@ import { emblBreadcrumbs } from "@visual-framework/embl-breadcrumbs-lookup/embl-
export class EmblBreadcrumbs extends React.Component {
componentDidMount() {
// window.setTimeout(function() {
emblBreadcrumbs();
// }, 700);
}
render() {
return (
......
src/components/EmblFooter.jsx
View file @ fe914289
......@@ -3,9 +3,7 @@ import { emblContentHub } from "@visual-framework/embl-content-hub-loader/embl-c
export class EmblFooter extends React.Component {
componentDidMount() {
// window.setTimeout(function() {
emblContentHub();
// }, 700);
}
render() {
return (
......
src/components/Html.jsx
View file @ fe914289
import React from "react";
export function Html({ html }) {
return (
<p
......
src/components/alerts/Alerts.jsx
View file @ fe914289
import { useRef, useState } from "react";
import { locationsWithCountries, positionTypes } from "data/jobs-data.json";
import { useRef } from "react";
import { useForm } from "react-hook-form";
import { EMAIL_VALIDATION_REGEX } from "../../helpers/helpers";
import { locationsWithCountries, positionTypes } from "data/jobs-data.json";
import "./Alerts.scss";
/* Subscription-alerts page, uses react-hook-form */
export function Alerts() {
const [subscriptionSuccess, setSubscriptionSuccess] = useState(false);
const [subscriptionFailure, setSubscriptionFailure] = useState(false);
const formRef = useRef();
const {
register,
......@@ -23,18 +20,16 @@ export function Alerts() {
});
const onSubmit = () => {
//console.log(formRef.current)
const formData = new FormData(formRef.current);
const params = new URLSearchParams(formData);
console.log(params.toString());
// formRef.current.submit();
fetch(`https://www.embl.de/jobs/searchjobs/index.php?${params.toString()}`)
.then(() => {
setSubscriptionSuccess(true);
})
.catch(() => {
setSubscriptionFailure(true);
});
formRef.current.submit();
// const formData = new FormData(formRef.current);
// const params = new URLSearchParams(formData);
// fetch(`https://www.embl.de/jobs/searchjobs/index.php?${params.toString()}`)
// .then(() => {
// setSubscriptionSuccess(true);
// })
// .catch(() => {
// setSubscriptionFailure(true);
// });
};
/*
......@@ -52,13 +47,6 @@ export function Alerts() {
disabled: allPosValue && allPosValue[0] === "0",
};
if (subscriptionSuccess) {
return <div>Sub success</div>;
}
if (subscriptionFailure) {
return <div>Sub failure</div>;
}
return (
<>
<section className="vf-intro" id="an-id-for-anchor">
......
src/components/apply/Apply.jsx
View file @ fe914289
import { useEffect } from "react";
import { Helmet } from "react-helmet";
import { Link } from "react-router-dom";
import { EmblHeader } from "../EmblHeader";
import { EmblBreadcrumbs } from "../EmblBreadcrumbs";
import { EmblFooter } from "../EmblFooter";
import { EmblHeader } from "../EmblHeader";
export function Apply() {
useEffect(() => {
//window.location.search = new URL(document.location).search;
}, []);
return (
<>
<EmblHeader />
......
src/components/content/HrExcellenceInResearch.jsx
View file @ fe914289
import { VfIntro } from "../../component-templates/VFIntro";
import ContentMeta from "./components/ContentMeta";
import { ContentMeta } from "./components/ContentMeta";
import { EMBLContentTemplate } from "./components/EMBLContentTemplate";
export function HrExcellenceInResearch() {
......
src/components/content/Partners.jsx
View file @ fe914289
import React from "react";
import { EMBLContentTemplate } from "./components/EMBLContentTemplate";
export function Partners() {
......
src/components/content/Science4Refugees.jsx
View file @ fe914289
import { VfIntro } from "../../component-templates/VFIntro";
import ContentMeta from "./components/ContentMeta";
import { ContentMeta } from "./components/ContentMeta";
import { EMBLContentTemplate } from "./components/EMBLContentTemplate";
export function Science4Refugees() {
......
src/components/content/components/ContentMeta.jsx
View file @ fe914289
import { Helmet } from "react-helmet";
export default function ContentMeta({ keywords, description, canonical }) {
export function ContentMeta({ keywords, description, canonical }) {
return (
<Helmet>
<meta name="keywords" content={keywords} />
......
src/components/content/components/EMBLContentTemplate.jsx
View file @ fe914289
import React from "react";
import { EmblBreadcrumbs } from "../../EmblBreadcrumbs";
import { EmblCards } from "../../EmblCards";
import { EmblFooter } from "../../EmblFooter";
import { EmblHeader } from "../../EmblHeader";
import "./styles.scss";
export function EMBLContentTemplate({ children }) {
return (
......
src/components/content/ebi/brexit.jsx deleted 100644 → 0
View file @ a64700f9
import React from "react";
import { VFCard } from "../../../component-templates/VFCard";
export default function Brexit() {
return (
<div>
{/* {# Intro #} */}
<section className="vf-intro | embl-grid embl-grid--has-centered-content">
<div></div>
<div>
<h1 className="vf-intro__heading">EMBL-EBI and Brexit</h1>
<p className="vf-lede">
EMBL is a European intergovernmental organisation and is not
formally linked to the European Union.
</p>
<div className="embed-container">
<iframe
id="postdocvideo"
src="https://www.youtube.com/embed/8mg5VhRF7Pk?enablejsapi=1"
frameBorder="0"
allowFullScreen
></iframe>
</div>
<p className="vf-intro__text">
<br />
We recruit staff and scientists from all over the world and we
strongly believe science is fundamentally international.
</p>
<p className="vf-intro__text">
EMBL is funded by over{" "}
<a href="https://www.embl.de/aboutus/general_information/organisation/member_states/">
20 member states and associate member states
</a>
, including the United Kingdom. The UK’s participation in EMBL will
not change as a result of Brexit.
</p>
</div>
</section>
<section className="embl-grid embl-grid--has-centered-contentXX | vf-u-padding__top--lg">
<div className="">
<h3 className="vf-links__heading">In this section</h3>
</div>
<div className="vf-links vf-links__list--easy">
<ul className="vf-links__list | vf-list">
<ul className="vf-list__item">
<a className="vf-list__link" href="#questions">
Brexit questions
<svg
className="vf-icon vf-icon__arrow--down | vf-list__icon"
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 24 24"
>
<path d="M.249,7.207,11.233,19.678h0a1.066,1.066,0,0,0,1.539,0L23.751,7.207a.987.987,0,0,0-.107-1.414l-1.85-1.557a1.028,1.028,0,0,0-1.438.111L12.191,13.8a.25.25,0,0,1-.379,0L3.644,4.346A1.021,1.021,0,0,0,2.948,4a1,1,0,0,0-.741.238L.356,5.793A.988.988,0,0,0,0,6.478.978.978,0,0,0,.249,7.207Z"></path>
</svg>
</a>
</ul>
<ul className="vf-list__item">
<a className="vf-list__link" href="#join">
Joining EMBL-EBI
<svg
className="vf-icon vf-icon__arrow--down | vf-list__icon"
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 24 24"
>
<path d="M.249,7.207,11.233,19.678h0a1.066,1.066,0,0,0,1.539,0L23.751,7.207a.987.987,0,0,0-.107-1.414l-1.85-1.557a1.028,1.028,0,0,0-1.438.111L12.191,13.8a.25.25,0,0,1-.379,0L3.644,4.346A1.021,1.021,0,0,0,2.948,4a1,1,0,0,0-.741.238L.356,5.793A.988.988,0,0,0,0,6.478.978.978,0,0,0,.249,7.207Z"></path>
</svg>
</a>
</ul>
<ul className="vf-list__item">
<a className="vf-list__link" href="#impact">
EMBL-EBI's impact
<svg
className="vf-icon vf-icon__arrow--down | vf-list__icon"
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 24 24"
>
<path d="M.249,7.207,11.233,19.678h0a1.066,1.066,0,0,0,1.539,0L23.751,7.207a.987.987,0,0,0-.107-1.414l-1.85-1.557a1.028,1.028,0,0,0-1.438.111L12.191,13.8a.25.25,0,0,1-.379,0L3.644,4.346A1.021,1.021,0,0,0,2.948,4a1,1,0,0,0-.741.238L.356,5.793A.988.988,0,0,0,0,6.478.978.978,0,0,0,.249,7.207Z"></path>
</svg>
</a>
</ul>
</ul>
</div>
</section>
<section className="embl-grid embl-grid--has-centered-contentXX | vf-u-padding__top--xl">
<div className="vf-section-header">
<h2 className="vf-section-header__heading" id="questions">
Common Brexit topics
</h2>
<p>
These cover the most frequent question by staff and prospective
hires. If you have any questions about working with us{" "}
<a href="mailto:brexit_info@ebi.ac.uk" className="vf-link">
please get in touch
</a>
.
</p>
</div>
<div className="vf-content">
<dl className="vf-dl">
<dt className="vf-dl--dt">Who can work at EMBL-EBI?</dt>
<dd className="vf-dl--dd">
We hire talented people from all over the world, regardless of
their country of origin or nationality. EMBL-EBI employees
benefit, and will continue to benefit from exemption from visa
restrictions due to our intergovernmental status. The spouses and
legal partners of EMBL-EBI employees are not restricted from
living and working in the UK*.
</dd>
<dt className="vf-dl--dt">Can I bring my family?</dt>
<dd className="vf-dl--dd">
The EMBL-EBI visa exemption also applies to the spouses/legal
partners and children of our staff*. We offer a wide range of
family-related benefits to help you set up your new life in the
UK. These may include support for education fees, language
courses, private health insurance, a relocation allowance and
other family-related allowances.
</dd>
<dt className="vf-dl--dt">Will EMBL-EBI move out of the UK?</dt>
<dd className="vf-dl--dd">
EMBL-EBI will not move out of the UK in the foreseeable future. We
benefit from the continuous support of the UK Government and are
an essential part of the Cambridge biotech cluster, which is
driving life science research.
</dd>
<dt className="vf-dl--dt">Will EMBL-EBI funding be affected?</dt>
<dd className="vf-dl--dd">
EMBL is funded directly by our member states, but we also benefit
from a wide range of European Commission (EC) grants. Brexit does
not affect EMBL’s relationship with the EC, so EMBL-EBI staff will
continue to be eligible for EC funding.{" "}
</dd>
<dt className="vf-dl--dt">
Will EMBL-EBI scientific collaborations be affected?
</dt>
<dd className="vf-dl--dd">
EMBL was founded on the principle of international collaboration,
and our success over the years is built on that. Our researchers
collaborate intensively with scientists around the world and the
UK’s decision to leave the EU will not change this.
</dd>
<dt className="vf-dl--dt">What is life in Cambridgeshire like?</dt>
<dd className="vf-dl--dd">
Cambridge is a small city that is home to an international
community. It is a vibrant place with many cultural and
professional opportunities, a hugely diverse population and a
large student community. There are many chances to socialise and
meet people with similar interests. It is a supportive and safe
environment with easy access to London, the rest of the UK and
Europe.
</dd>
<dt className="vf-dl--dt">What is EMBL’s status?</dt>
<dd className="vf-dl--dd">
EMBL is a European intergovernmental organisation and is not
formally linked to the European Union. The UK’s membership of EMBL
is independent of its membership of the EU. EMBL was established
by international treaty between its member states, not all of
which are members of the EU. The UK was a founding member of EMBL
and we look forward to developing our constructive relationship
with the UK long into the future.
</dd>
</dl>
*some exceptions may apply
</div>
</section>
<section className="embl-grid embl-grid--has-centered-contentXX | vf-u-padding__top--xl">
<div className="vf-section-header">
<h2 className="vf-section-header__heading" id="join">
Joining EMBL-EBI{" "}
</h2>
</div>
<div className="vf-grid vf-grid__col-2">
<VFCard
card_href="//www.ebi.ac.uk/about/jobs/career-profiles"
modifier="normal"
variant="very-easy"
card_image="https://acxngcvroo.cloudimg.io/v7/https://www.ebi.ac.uk/sites/ebi.ac.uk/files/shared/images/PHOTOS/Campus/EBI_dusk.jpg"
card_title="Life at EMBL-EBI"
card_text="Outstanding technical infrastructure and a flexible working style, EMBL-EBI is a medium-sized organisation with a small-company feel."
/>
<VFCard
card_href="/jobs/work-at-embl"
modifier="normal"
variant="very-easy"
card_image="https://acxngcvroo.cloudimg.io/v7/https://www.embl.org/files/wp-content/uploads/2020/04/0607_ells-school-group_hd-s.jpg"
card_title="Benefits and recruitment"
card_text="We offer attractive conditions and benefits to attract and retain the brightest talent."
/>
<VFCard
card_href="/jobs/ebi"
modifier="normal"
variant="very-easy"
card_image="https://i.ytimg.com/vi/gXDLvQgF8Hw/maxresdefault.jpg"
card_title="Jobs at EMBL-EBI"
card_text="View all"
/>
</div>
</section>
<section className="embl-grid embl-grid--has-centered-contentXX | vf-u-padding__top--xl">
<div className="vf-section-header">
<h2 className="vf-section-header__heading" id="impact">
EMBL-EBI: Our impact
</h2>
</div>
<div className="vf-grid vf-grid__col-2">
<section>
<p className="vf-lede">
We collaborate with scientists and engineers all over the world,
and provide the infrastructure needed to share data openly in the
life sciences.
</p>
<p className="vf-intro__text">
<br />
Understanding how genetics affects the health of humans, plants
and animals is essential to advances in disease prevention, food
security and biodiversity.
</p>
<p className="vf-intro__text">
<a
href="https://www.ebi.ac.uk/about/our-impact"
className="vf-link"
>
Learn more about EMBL-EBI's impact
</a>
</p>
</section>
<section>
{/* <style>.embed-container{position:relative;padding-bottom:56.25%;height:0;overflow:hidden;max-width:100%}.embed-container embed,.embed-container iframe,.embed-container object{position:absolute;top:0;left:0;width:100%;height:100%}</style> */}
<div className="embed-container">
<iframe
src="https://www.youtube.com/embed/0H0v3RMY6eg"
frameBorder="0"
allowFullScreen
></iframe>
</div>
</section>
</div>
</section>
</div>
);
}
src/components/content/work-at-embl/GroupLeaderRecruitment.jsx
View file @ fe914289
import { VfIntro } from "../../../component-templates/VFIntro";
import ContentMeta from "../components/ContentMeta";
import { ContentMeta } from "../components/ContentMeta";
import { EMBLContentTemplate } from "../components/EMBLContentTemplate";
export function GroupLeaderRecruitment() {
......
src/components/content/work-at-embl/conditions-employment/ConditionsEmployment.jsx
View file @ fe914289
import { VfIntro } from "component-templates/VFIntro";
import { EMBLContentTemplate } from "components/content/components/EMBLContentTemplate";
import { VfSummary } from "../../../../component-templates/VFSummary";
import ContentMeta from "../../components/ContentMeta";
import { ContentMeta } from "../../components/ContentMeta";
export function ConditionsEmployment() {
return (
......
src/components/content/work-at-embl/conditions-employment/FamilyLife.jsx
View file @ fe914289
import { VfIntro } from "component-templates/VFIntro";
import { EMBLContentTemplate } from "components/content/components/EMBLContentTemplate";
import ContentMeta from "../../components/ContentMeta";
import { ContentMeta } from "../../components/ContentMeta";
export function FamilyLife() {
return (
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment