Unverified Commit 59f1dfb8 authored by Ken Hawkins's avatar Ken Hawkins Committed by GitHub
Browse files

bug: vf-stack inheritance for contentHub (#1725)

* bug: vf-stack inheritance for contentHub

contentHub html responses are nested deep in many layers of divs, so we ensure a default vf--stack applies to grid containers.
parent 658071aa
### 1.2.0
* contentHub html responses are nested deep in many layers of divs, so we ensure a default vf--stack applies to grid containers.
* https://github.com/visual-framework/vf-core/pull/1725
### 1.1.1
* Avoid a null variable issue when contentHub returns no results.
......
......@@ -18,11 +18,11 @@
.vf-grid > .embl-content-hub-html {
grid-column: 1 / -1;
// @todo: this should probably just be .embl-content-hub-html, but that requires a
// disruptive change in the contenthub itself and will impact many systems.
// disruptive change in the contentHub itself and will impact many systems.
// that change will require coordination
}
// contentHub html is sometimes placed as a direct child of `vf-body` which needs a
// different grid-column ruleset.
// different grid-column rule set.
.vf-body > .vf-content-hub-html,
.vf-body > .embl-content-hub-html {
grid-column: main;
......@@ -38,3 +38,19 @@
.vf-content-hub-html {
--vf-stack-margin--custom: 0;
}
// contentHub html responses are nested deep in divitis,
// so we ensure a default vf--stack applies to grid containers
.vf-stack .vf-content-hub-html .embl-grid,
.vf-stack .vf-content-hub-html .vf-grid,
.vf-stack .vf-content-hub-html .vf-content > * {
--vf-stack-margin: 1rem;
--vf-stack-margin--custom: 1rem;
margin-top: var(--vf-stack-margin, 1rem);
}
.vf-stack .vf-content-hub-html .embl-grid > *,
.vf-stack .vf-content-hub-html .vf-grid > *,
.vf-stack .vf-content-hub-html .vf-content > * > * {
--vf-stack-margin: 0;
--vf-stack-margin--custom: 0
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment