Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Open sidebar
embl.org
vf-core-mirror
Commits
b5ca120f
Commit
b5ca120f
authored
Dec 08, 2021
by
Ken Hawkins
Browse files
VF content defentition list support, component library quick fixes
parent
5b7d491a
Pipeline
#221329
passed with stages
in 8 minutes and 26 seconds
Changes
6
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
32 additions
and
9 deletions
+32
-9
components/vf-content/CHANGELOG.md
components/vf-content/CHANGELOG.md
+4
-0
components/vf-content/vf-content.njk
components/vf-content/vf-content.njk
+13
-0
components/vf-content/vf-content.scss
components/vf-content/vf-content.scss
+9
-0
components/vf-list/vf-list.scss
components/vf-list/vf-list.scss
+4
-4
tools/vf-component-library/src/site/developing/getting-started/setting-up.njk
...ibrary/src/site/developing/getting-started/setting-up.njk
+1
-1
tools/vf-component-library/src/site/patterns/article.njk
tools/vf-component-library/src/site/patterns/article.njk
+1
-4
No files found.
components/vf-content/CHANGELOG.md
View file @
b5ca120f
### 1.6.7
*
Add support for definition lists.
### 1.6.3
*
Dependency bumps.
...
...
components/vf-content/vf-content.njk
View file @
b5ca120f
...
...
@@ -31,6 +31,19 @@
- A bulleted item
- A bulleted item
### Definition lists
<dl>
<dt>Beast of Bodmin</dt>
<dd>A large feline inhabiting Bodmin Moor.</dd>
<dt>Morgawr</dt>
<dd>A sea serpent.</dd>
<dt>Owlman</dt>
<dd>A giant owl-like creature.</dd>
</dl>
{% endmarkdown %}
<table>
...
...
components/vf-content/vf-content.scss
View file @
b5ca120f
...
...
@@ -122,6 +122,15 @@
margin-bottom
:
map-get
(
$vf-spacing-map
,
vf-spacing--400
);
}
dl
:not
([
class
*=
'vf-'
])
{
dt
:not
([
class
*=
'vf-'
])
{
@include
set-type
(
text-heading--4
,
$custom-margin-bottom
:
8px
);
}
dd
:not
([
class
*=
'vf-'
])
{
@include
set-type
(
text-body--2
);
}
}
img
:not
([
class
*=
'vf-'
])
{
height
:
auto
;
max-width
:
100%
;
...
...
components/vf-list/vf-list.scss
View file @
b5ca120f
...
...
@@ -26,11 +26,11 @@
// VF definition lists
// https://github.com/visual-framework/vf-core/issues/914
.vf-list--definition
{
@include
list
(
vf-list--unordered
,
unordered
);
}
//
.vf-list--definition {
//
@include list(vf-list--unordered, unordered);
//
}
.vf-list--definition__term
{
@include
set-type
(
text-heading--4
);
@include
set-type
(
text-heading--4
,
$custom-margin-bottom
:
8px
);
}
.vf-list--definition__details
{
@include
set-type
(
text-body--2
);
...
...
tools/vf-component-library/src/site/developing/getting-started/setting-up.njk
View file @
b5ca120f
...
...
@@ -46,7 +46,7 @@ We have a recommended development environment for new developers:
<div class="vf-box vf-box-theme-- vf-box- vf-box-theme--quinary">
<h4 class=" vf-box__heading">Problems?</h4>
<p class="vf-box__text">See the <a href="
(
{{ '/troubleshooting' | url}}
)
" class="vf-link">troubleshooting guide</a>.</p>
<p class="vf-box__text">See the <a href="{{ '/troubleshooting' | url}}" class="vf-link">troubleshooting guide</a>.</p>
</div>
### Developing the VF Core
...
...
tools/vf-component-library/src/site/patterns/article.njk
View file @
b5ca120f
...
...
@@ -187,10 +187,7 @@ layout: layouts/boilerplate.njk
"text": "Version, 1982, Adenovirus with 217 dots.",
"alttext": "hello alt text",
"imageUrl": "../../assets/vf-figure/assets/figure-example.png"
}
%}
{% render '@vf-figure', context %}
{# vf-figure needs template updates to work with include #}
} %}
{% include "vf-core-components/vf-figure/vf-figure.njk" %}
</section>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment