From 11c13a7c6826ed65f9f67002befe98b8be870d21 Mon Sep 17 00:00:00 2001
From: Leo Gordon <lg4@ebi.ac.uk>
Date: Thu, 16 Sep 2010 10:47:39 +0000
Subject: [PATCH] make retry_throwing_jobs=1 by default to avoid confusion

---
 modules/Bio/EnsEMBL/Hive/Worker.pm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/modules/Bio/EnsEMBL/Hive/Worker.pm b/modules/Bio/EnsEMBL/Hive/Worker.pm
index 5064e660a..b1cb9e51e 100755
--- a/modules/Bio/EnsEMBL/Hive/Worker.pm
+++ b/modules/Bio/EnsEMBL/Hive/Worker.pm
@@ -312,9 +312,10 @@ sub last_check_in {
 # this is a setter/getter that defines default behaviour when a job throws: should it be retried or not?
 
 sub retry_throwing_jobs {
-  my( $self, $value ) = @_;
-  $self->{'_retry_throwing_jobs'} = $value if($value);
-  return $self->{'_retry_throwing_jobs'} || 0;
+    my $self = shift @_;
+
+    $self->{'_retry_throwing_jobs'} = shift @_ if(@_);
+    return defined($self->{'_retry_throwing_jobs'}) ? $self->{'_retry_throwing_jobs'} : 1;
 }
 
 =head2 hive_output_dir
-- 
GitLab