From c01a3433271be59bd1920a49fe1f3390e6045cc0 Mon Sep 17 00:00:00 2001
From: Jessica Severin <jessica@ebi.ac.uk>
Date: Tue, 9 Aug 2005 16:04:49 +0000
Subject: [PATCH] added code to catch an exception at the job level, reset/fail
that job yet allow the worker to continue working. Previous design killed
the worker when one of it's jobs fails. This new design should be more
efficient yet still provide some level of inter-job-mangle-proof-ness.
---
modules/Bio/EnsEMBL/Hive/Worker.pm | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/modules/Bio/EnsEMBL/Hive/Worker.pm b/modules/Bio/EnsEMBL/Hive/Worker.pm
index 24f254f4a..35e9ba30d 100755
--- a/modules/Bio/EnsEMBL/Hive/Worker.pm
+++ b/modules/Bio/EnsEMBL/Hive/Worker.pm
@@ -418,15 +418,21 @@ sub run
}
foreach my $job (@{$jobs}) {
-
- $self->redirect_job_output($job);
- $self->run_module_with_job($job);
- $self->close_and_update_job_output($job);
-
- $self->queen->worker_register_job_done($self, $job);
-
- $self->{'_work_done'}++;
+ eval {
+ $self->redirect_job_output($job);
+ $self->run_module_with_job($job);
+ $self->close_and_update_job_output($job);
+
+ $self->queen->worker_register_job_done($self, $job);
+ $self->work_done($self->work_done + 1);
+ };
+ if($@) {
+ #job threw an exception so it had a problem
+ printf("job %d failed with exception: $@\n", $job->dbID);
+ $self->queen->db->get_AnalysisJobAdaptor->reset_dead_job_by_dbID($job->dbID);
+ }
}
+
my $batch_end = time() * 1000;
#printf("batch start:%f end:%f\n", $batch_start, $batch_end);
$self->db->get_AnalysisStatsAdaptor->
--
GitLab