bugfix: if re-running a job that creates a semaphored group, we no longer die...

bugfix: if re-running a job that creates a semaphored group, we no longer die (thanks Miguel for reporting)

modules/Bio/EnsEMBL/Hive/AnalysisJob.pm

@@ -329,9 +329,7 @@ sub dataflow_output_id {
                         if($failed_to_create) { # adjust semaphore_count for jobs that failed to create:
                             $self->adaptor->decrease_semaphore_count_for_jobid( $funnel_job_id, $failed_to_create );
                         }
-
-                    } else {
-                        die "Could not create a funnel job";
+                    } else {    # assume the whole semaphored group of jobs has been created already
                     }
 
                 } else {    # non-semaphored dataflow (but potentially propagating any existing semaphores)

modules/Bio/EnsEMBL/Hive/DBSQL/AnalysisJobAdaptor.pm

@@ -142,6 +142,7 @@ sub CreateNewJob {
              WHERE analysis_id=$analysis_id
           });
       }
+  } else {  #   if we got 0E0, it means "ignored insert collision" (job created previously), so we simply return an undef and deal with it outside
   }
 
   return $job_id;