From 41d7119986a8215627c9a5161f2f67cb5a586acb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andreas=20Kusalananda=20K=C3=A4h=C3=A4ri?=
<ak4@sanger.ac.uk>
Date: Fri, 27 Aug 2010 08:18:31 +0000
Subject: [PATCH] Allow $translation->transcript(undef) to break connection to
translation's transcript.
---
modules/Bio/EnsEMBL/Translation.pm | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/modules/Bio/EnsEMBL/Translation.pm b/modules/Bio/EnsEMBL/Translation.pm
index 952ebdfcac..d4955f5004 100755
--- a/modules/Bio/EnsEMBL/Translation.pm
+++ b/modules/Bio/EnsEMBL/Translation.pm
@@ -56,6 +56,7 @@ use Scalar::Util qw(weaken);
use Bio::EnsEMBL::Utils::Exception qw( deprecate throw warning );
use Bio::EnsEMBL::Utils::Argument qw( rearrange );
+use Bio::EnsEMBL::Utils::Scalar qw( assert_ref );
use Bio::EnsEMBL::Storable;
@@ -153,16 +154,15 @@ sub transcript {
my ( $self, $transcript ) = @_;
if ( defined($transcript) ) {
- if ( !ref($transcript)
- || !$transcript->isa('Bio::EnsEMBL::Transcript') )
- {
- throw("Argument is not a transcript");
- }
+ assert_ref( $transcript, 'Bio::EnsEMBL::Transcript' );
$self->{'transcript'} = $transcript;
weaken( $self->{'transcript'} ); # Avoid circular references.
+ } elsif ( @_ > 1 ) {
+ # Break connection to transcript.
+ delete( $self->{'transcript'} );
} elsif ( !defined( $self->{'transcript'} ) ) {
my $adaptor = $self->{'adaptor'};
if ( !defined($adaptor) ) {
@@ -180,10 +180,10 @@ sub transcript {
$adaptor->db()->get_TranscriptAdaptor()
->fetch_by_translation_id($dbID);
- # Do not weaken the reference if we had to get the transcript from the
- # database. The user is probably working on translations directly,
- # not going through transcripts.
- #weaken( $self->{'transcript'} ); # Avoid circular references.
+ # Do not weaken the reference if we had to get the transcript from the
+ # database. The user is probably working on translations directly,
+ # not going through transcripts.
+ #weaken( $self->{'transcript'} ); # Avoid circular references.
}
return $self->{'transcript'};
--
GitLab