From 422ebc59c32c059d3cd2768934eae49ce0957cdf Mon Sep 17 00:00:00 2001
From: ens-carlos <ens-carlos@users.noreply.github.com>
Date: Thu, 30 Nov 2017 13:47:29 +0000
Subject: [PATCH] Throw if features array is empty and moved checks to the top.
---
modules/Bio/EnsEMBL/BaseAlignFeature.pm | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/modules/Bio/EnsEMBL/BaseAlignFeature.pm b/modules/Bio/EnsEMBL/BaseAlignFeature.pm
index 82260e1792..a6be1f65ef 100644
--- a/modules/Bio/EnsEMBL/BaseAlignFeature.pm
+++ b/modules/Bio/EnsEMBL/BaseAlignFeature.pm
@@ -676,13 +676,15 @@ my $message_only_once = 1;
sub _parse_ensembl_features {
my ($self,$features ) = @_;
- my $query_unit = $self->_query_unit();
- my $hit_unit = $self->_hit_unit();
-
if (ref($features) ne "ARRAY") {
throw("features must be an array reference not a [".ref($features)."]");
+ } elsif (scalar(@$features) <= 0) {
+ throw("features array must not be empty");
}
+ my $query_unit = $self->_query_unit();
+ my $hit_unit = $self->_hit_unit();
+
my $strand = $features->[0]->strand;
throw ('FeaturePair needs to have strand == 1 or strand == -1') if(!$strand);
--
GitLab