Commit 4e00396a authored by Andreas Kusalananda Kähäri's avatar Andreas Kusalananda Kähäri
Browse files

Change the default for _has_analysis() from false (zero) to true (1) to

decrease the amount of code (slightly) in most of the feature-specific
sub-classes.
parent cbc8c2e8
...@@ -1083,8 +1083,8 @@ sub _dbID_column { ...@@ -1083,8 +1083,8 @@ sub _dbID_column {
in their main feature table. For these feature in their main feature table. For these feature
types, a restriction on analysis.logic_name may types, a restriction on analysis.logic_name may
be enforced by using the ANALYSIS argument of the be enforced by using the ANALYSIS argument of the
constructor. This method should return a true constructor. This method should return a false
value if there is such an analysis_id column in value if there is no such an analysis_id column in
the feature table. the feature table.
Return type : Boolean Return type : Boolean
...@@ -1097,7 +1097,7 @@ sub _dbID_column { ...@@ -1097,7 +1097,7 @@ sub _dbID_column {
=cut =cut
sub _has_analysis { return 0 } sub _has_analysis { return 1 }
#----------------------------------------------------------------------- #-----------------------------------------------------------------------
......
...@@ -31,7 +31,7 @@ sub _extra_columns { ...@@ -31,7 +31,7 @@ sub _extra_columns {
# sub _extra_where_clause { } # sub _extra_where_clause { }
sub _has_analysis { return 1 } # sub _has_analysis { return 1 }
#----------------------------------------------------------------------- #-----------------------------------------------------------------------
# Implemented abstract protected methods from base class # Implemented abstract protected methods from base class
......
...@@ -35,7 +35,7 @@ sub _extra_where_clause { ...@@ -35,7 +35,7 @@ sub _extra_where_clause {
); );
} }
# sub _has_analysis { return 0 } sub _has_analysis { return 0 }
#----------------------------------------------------------------------- #-----------------------------------------------------------------------
# Implemented abstract protected methods from base class # Implemented abstract protected methods from base class
......
...@@ -37,7 +37,7 @@ sub _extra_where_clause { ...@@ -37,7 +37,7 @@ sub _extra_where_clause {
); );
} }
sub _has_analysis { return 1 } # sub _has_analysis { return 1 }
#----------------------------------------------------------------------- #-----------------------------------------------------------------------
# Implemented abstract protected methods from base class # Implemented abstract protected methods from base class
......
...@@ -30,7 +30,7 @@ sub _extra_columns { ...@@ -30,7 +30,7 @@ sub _extra_columns {
# sub _extra_where_clause { } # sub _extra_where_clause { }
sub _has_analysis { return 1 } # sub _has_analysis { return 1 }
#----------------------------------------------------------------------- #-----------------------------------------------------------------------
# Implemented abstract protected methods from base class # Implemented abstract protected methods from base class
......
...@@ -36,7 +36,7 @@ sub _extra_where_clause { ...@@ -36,7 +36,7 @@ sub _extra_where_clause {
return 'rc.repeat_consensus_id = rf.repeat_consensus_id'; return 'rc.repeat_consensus_id = rf.repeat_consensus_id';
} }
sub _has_analysis { return 1 } # sub _has_analysis { return 1 }
#----------------------------------------------------------------------- #-----------------------------------------------------------------------
# Implemented abstract protected methods from base class # Implemented abstract protected methods from base class
......
...@@ -30,7 +30,7 @@ sub _extra_where_clause { ...@@ -30,7 +30,7 @@ sub _extra_where_clause {
); );
} }
sub _has_analysis { return 1 } # sub _has_analysis { return 1 }
#----------------------------------------------------------------------- #-----------------------------------------------------------------------
# Implemented abstract protected methods from base class # Implemented abstract protected methods from base class
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment