Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Open sidebar
ensembl-gh-mirror
ensembl
Commits
5941e41e
Commit
5941e41e
authored
Mar 19, 2019
by
Marek Szuba
Browse files
Document the use of ## no critic in comments
parent
3821b930
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
10 additions
and
0 deletions
+10
-0
modules/Bio/EnsEMBL/DBSQL/RNAProductAdaptor.pm
modules/Bio/EnsEMBL/DBSQL/RNAProductAdaptor.pm
+1
-0
modules/Bio/EnsEMBL/MicroRNA.pm
modules/Bio/EnsEMBL/MicroRNA.pm
+1
-0
modules/Bio/EnsEMBL/RNAProduct.pm
modules/Bio/EnsEMBL/RNAProduct.pm
+7
-0
modules/t/rnaProduct.t
modules/t/rnaProduct.t
+1
-0
No files found.
modules/Bio/EnsEMBL/DBSQL/RNAProductAdaptor.pm
View file @
5941e41e
...
...
@@ -565,6 +565,7 @@ sub _obj_from_sth {
=cut
# This method IS used, at the superclass level
sub
_tables
{
## no critic (Subroutines::ProhibitUnusedPrivateSubroutines)
return
(['
rnaproduct
',
'
rp
']);
}
...
...
modules/Bio/EnsEMBL/MicroRNA.pm
View file @
5941e41e
...
...
@@ -92,6 +92,7 @@ use parent qw(Bio::EnsEMBL::RNAProduct);
=cut
# perlcritic doesn't know about rearrange(), silence it
sub
new
{
## no critic (Subroutines::RequireArgUnpacking)
my
$caller
=
shift
;
...
...
modules/Bio/EnsEMBL/RNAProduct.pm
View file @
5941e41e
...
...
@@ -103,6 +103,7 @@ use parent qw(Bio::EnsEMBL::Storable);
=cut
# perlcritic doesn't know about rearrange(), silence it
sub
new
{
## no critic (Subroutines::RequireArgUnpacking)
my
$caller
=
shift
;
...
...
@@ -524,6 +525,7 @@ sub get_all_DBEntries {
=cut
# this is an alias, we do NOT want to unpack @_
sub
get_all_DBLinks
{
## no critic (Subroutines::RequireArgUnpacking)
my
$self
=
shift
;
return
$self
->
get_all_DBEntries
(
@
_
);
...
...
@@ -554,6 +556,7 @@ sub get_all_DBLinks { ## no critic (Subroutines::RequireArgUnpacking)
=cut
# this is an alias, we do NOT want to unpack @_
sub
get_all_object_xrefs
{
## no critic (Subroutines::RequireArgUnpacking)
my
$self
=
shift
;
return
$self
->
get_all_DBEntries
(
@
_
);
...
...
@@ -580,6 +583,7 @@ sub get_all_object_xrefs { ## no critic (Subroutines::RequireArgUnpacking)
=cut
# this is an alias, we do NOT want to unpack @_
sub
get_all_xrefs
{
## no critic (Subroutines::RequireArgUnpacking)
my
$self
=
shift
;
return
$self
->
get_all_DBLinks
(
@
_
);
...
...
@@ -619,6 +623,9 @@ sub modified_date {
=cut
# PBP do allow homonyms as methods but perlcritic cannot, tell these
# apart from the forbidden ones, as stated in the documentation of the
# relevant policy
sub
length
{
## no critic (Subroutines::ProhibitBuiltinHomonyms)
my
$self
=
shift
;
my
$seq
=
$self
->
seq
();
...
...
modules/t/rnaProduct.t
View file @
5941e41e
...
...
@@ -13,6 +13,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# This would go against this repository's convention for naming test files
## no critic (RequireFilenameMatchesPackage)
package
RNAProductTests
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment