diff --git a/modules/Bio/EnsEMBL/DBSQL/BaseFeatureAdaptor.pm b/modules/Bio/EnsEMBL/DBSQL/BaseFeatureAdaptor.pm index ccbb96433d5f5d2c6b0746fd86bbd516bc64ad00..2d83ec673785fc8799cea59e340c84f1d3c493a0 100644 --- a/modules/Bio/EnsEMBL/DBSQL/BaseFeatureAdaptor.pm +++ b/modules/Bio/EnsEMBL/DBSQL/BaseFeatureAdaptor.pm @@ -450,6 +450,11 @@ sub fetch_all_by_Slice_constraint { if ( exists( $cache->{$key} ) ) { # Clear the bound parameters and return the cached data. $self->{'_bind_param_generic_fetch'} = (); + #IMPORTANT: NEVER EVER RETURN A COPY OF THE DATA STRUCTURE. + # This will hold arrays of values. Since we've been doing + # this for so long people are expecting multiple calls + # to fetch_by_SliceXXXXX() methods to return the same + # array reference. return $cache->{$key}; } } ## end if ( !( defined( $self...)))