From b977e0204720ed6a693eae65c1c99e4bcd538841 Mon Sep 17 00:00:00 2001
From: Andrew Yates <ayates@ebi.ac.uk>
Date: Thu, 12 Sep 2013 09:16:51 +0000
Subject: [PATCH] Making a note to never ever retire this bit of code
---
modules/Bio/EnsEMBL/DBSQL/BaseFeatureAdaptor.pm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/modules/Bio/EnsEMBL/DBSQL/BaseFeatureAdaptor.pm b/modules/Bio/EnsEMBL/DBSQL/BaseFeatureAdaptor.pm
index ccbb96433d..2d83ec6737 100644
--- a/modules/Bio/EnsEMBL/DBSQL/BaseFeatureAdaptor.pm
+++ b/modules/Bio/EnsEMBL/DBSQL/BaseFeatureAdaptor.pm
@@ -450,6 +450,11 @@ sub fetch_all_by_Slice_constraint {
if ( exists( $cache->{$key} ) ) {
# Clear the bound parameters and return the cached data.
$self->{'_bind_param_generic_fetch'} = ();
+ #IMPORTANT: NEVER EVER RETURN A COPY OF THE DATA STRUCTURE.
+ # This will hold arrays of values. Since we've been doing
+ # this for so long people are expecting multiple calls
+ # to fetch_by_SliceXXXXX() methods to return the same
+ # array reference.
return $cache->{$key};
}
} ## end if ( !( defined( $self...)))
--
GitLab