From c2ec40c06f9c2af627a29d9e23e6fd5e02b19bfd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20Kusalananda=20K=C3=A4h=C3=A4ri?= <ak4@sanger.ac.uk> Date: Thu, 30 Oct 2008 14:38:43 +0000 Subject: [PATCH] When using DBI::quote(), specify the SQL data type. --- .../Bio/EnsEMBL/DBSQL/BaseAlignFeatureAdaptor.pm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/modules/Bio/EnsEMBL/DBSQL/BaseAlignFeatureAdaptor.pm b/modules/Bio/EnsEMBL/DBSQL/BaseAlignFeatureAdaptor.pm index 691e15cab4..2de078b394 100644 --- a/modules/Bio/EnsEMBL/DBSQL/BaseAlignFeatureAdaptor.pm +++ b/modules/Bio/EnsEMBL/DBSQL/BaseAlignFeatureAdaptor.pm @@ -126,8 +126,10 @@ sub fetch_all_by_Slice_and_external_db { } my $constraint = sprintf( "%s.db_name = %s", - $edb_alias, - $self->dbc()->db_handle()->quote($external_db_name) ); + $edb_alias, + $self->dbc()->db_handle() + ->quote( $external_db_name, SQL_VARCHAR ) + ); return $self->fetch_all_by_Slice_constraint( $slice, $constraint, @@ -211,8 +213,8 @@ sub fetch_all_by_hit_name { my ( $name, $syn ) = @{ $tabs[0] }; my $constraint = sprintf( "%s.hit_name = %s", - $syn, - $self->dbc()->db_handle()->quote($hit_name) ); + $syn, + $self->dbc()->db_handle()->quote( $hit_name, SQL_VARCHAR ) ); if ( defined($logic_name) ) { # Add the $logic_name constraint @@ -258,8 +260,8 @@ sub fetch_all_by_hit_name_unversioned { my ( $name, $syn ) = @{ $tabs[0] }; my $constraint = sprintf( "%s.hit_name LIKE %s", - $syn, - $self->dbc()->db_handle()->quote( $hit_name . '.%' ) ); + $syn, + $self->dbc()->db_handle()->quote( $hit_name . '.%', SQL_VARCHAR ) ); if ( defined($logic_name) ) { # Add the $logic_name constraint -- GitLab