From d672f1238cfceb70f83b1b84f9b9fa422832f3ed Mon Sep 17 00:00:00 2001
From: Glenn Proctor <gp1@sanger.ac.uk>
Date: Wed, 22 Nov 2006 13:28:44 +0000
Subject: [PATCH] Use external_dbs.txt by default.
Allow comments in files.
Skip whitespace-only or blank lines.
---
misc-scripts/external_db/update_external_dbs.pl | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/misc-scripts/external_db/update_external_dbs.pl b/misc-scripts/external_db/update_external_dbs.pl
index 2ac899ace2..805e3e2c2f 100644
--- a/misc-scripts/external_db/update_external_dbs.pl
+++ b/misc-scripts/external_db/update_external_dbs.pl
@@ -33,6 +33,8 @@ usage("[DIE] Master database required\n\n") if (!$master);
$port ||= 3306;
+$file ||= "external_dbs.txt";
+
my $dsn = "DBI:mysql:host=$host;port=$port";
my $db = DBI->connect( $dsn, $user, $pass, {RaiseError => 1} );
@@ -71,6 +73,9 @@ my @rows;
my $row;
while ($row = <$fh>) {
chomp($row);
+ next if ($row =~ /^#/); # skip comments
+ next if ($row =~ /^$/); # and blank lines
+ next if ($row =~ /^\s+/); # and whitespace-only lines
my @a = split(/\t/, $row);
push @rows, {'external_db_id' => $a[0],
'db_name' => $a[1],
@@ -193,7 +198,8 @@ sub usage {
-release the release of the database to update used to
match database names. e.g. 13
-file the path of the file containing the insert statements
- of the entries of the external_db table
+ of the entries of the external_db table. Default is
+ external_dbs.txt
-dbnames db1
the names of the database to update. if not provided
all of the core databases matching the release arg
--
GitLab