From ddb71bb16587a1838f310eee1f391420db7e5944 Mon Sep 17 00:00:00 2001 From: Marek Szuba <marek.szuba@ebi.ac.uk> Date: Mon, 1 Oct 2018 14:55:29 +0100 Subject: [PATCH] Remove artificial dependency on XML::Simple The only part of the xref-mapping pipeline that depended on the long-deprecated module XML::Simple was TAIROntologyParser - which did not actually *use* that module for anything. Get rid of the useless import, thus making it unnecessary for XML::Simple to be mentioned in the cpanfile. --- cpanfile | 1 - misc-scripts/xref_mapping/XrefParser/TAIROntologyParser.pm | 1 - 2 files changed, 2 deletions(-) diff --git a/cpanfile b/cpanfile index d6db6bc66a..9e351e6f38 100644 --- a/cpanfile +++ b/cpanfile @@ -31,6 +31,5 @@ feature 'xref_mapping', 'Xref mapping pipeline' => sub { requires 'Digest::MD5'; requires 'Text::Glob'; requires 'XML::LibXML'; - requires 'XML::Simple'; }; =cut diff --git a/misc-scripts/xref_mapping/XrefParser/TAIROntologyParser.pm b/misc-scripts/xref_mapping/XrefParser/TAIROntologyParser.pm index bec960bb20..658b6b462a 100644 --- a/misc-scripts/xref_mapping/XrefParser/TAIROntologyParser.pm +++ b/misc-scripts/xref_mapping/XrefParser/TAIROntologyParser.pm @@ -102,7 +102,6 @@ use Data::Dumper; use File::Basename 'basename'; use Readonly; use List::MoreUtils 'uniq'; -use XML::Simple 'XMLin'; use base qw( XrefParser::BaseParser ); -- GitLab