From dec43aab01449a9839ffe70ff1a88f9bdebaf6ac Mon Sep 17 00:00:00 2001
From: Alistair Rust <rust@sanger.ac.uk>
Date: Thu, 2 Jan 2003 16:48:49 +0000
Subject: [PATCH] Always useful to store the updated values that you actually
 want. . .

---
 modules/Bio/EnsEMBL/DBSQL/GeneAdaptor.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/modules/Bio/EnsEMBL/DBSQL/GeneAdaptor.pm b/modules/Bio/EnsEMBL/DBSQL/GeneAdaptor.pm
index 7443fda691..02dd1377cc 100644
--- a/modules/Bio/EnsEMBL/DBSQL/GeneAdaptor.pm
+++ b/modules/Bio/EnsEMBL/DBSQL/GeneAdaptor.pm
@@ -1067,13 +1067,13 @@ sub update {
      if ( $update ) {
 
        $sth = $self->prepare("UPDATE gene
-                              SET    type = '$type',
-                                     analysis_id = $analysis,
-                                     display_xref_id = $dxref_id
+                              SET    type = ?,
+                                     analysis_id = ?,
+                                     display_xref_id = ?
                               WHERE  gene_id = ?
                             ");
 
-       $sth->execute($gene->dbID);
+       $sth->execute($gene->type, $gene->analysis->dbID, $gene->display_xref, $gene->dbID);
      }
    }
    else {
-- 
GitLab