GitLab

The type in this case is expressed using human-readable code, which is
then translated to numerical ID using data from the rnaproduct_type
table.

More useful, for instance for the upcoming implementation of
Transcript::get_all_RNAProducts() with type filtering. Drawback: must do
a join between rnaproduct and rnaproduct_type on all queries so that
RNAProductAdaptor has got something to put in this field.

Complete with relevant updates to RNAProductTypeMapper and its tests.

This will facilitate reusability because this bit of code will be the
same regardless of the SQL query invoked by the sth.

Uses the same type of SQL SELECT queries as Translation, which makes
sense given how similar they are.

Tested on test-genome-DBs/homo_sapiens/core, works without errors.

Aborts upon encountering a core database missing the 'rnaproduct' table
but that is in my humble opinion very much desired behaviour, as it could
indicate incomplete application of schema patches in the release this
will be included in.

There is now a dedicated class, Utils::RNAProductTypeMapper, which
provides type_id<->class_name mappings to both RNAProduct constructor
(with the side bonus of no longer having to set the type ID in the
constructor of each subclass) and RNAProductAdaptor. The latter will
likely be used more frequently than the former, therefore the default
map uses type IDs as keys; the reverse map is only generated the first
time it is needed.

In addition to the constructor, the RNAProductTypeMapper.pm defines a
function called mapper() which provides a singleton instance of the
mapper object.

The mappings are hardcoded instead of being retrieved from the database
because the latter could in principle result in execution of arbitrary
code.

Some tests have been defined as well.

1. List of arguments passed to the constructor now references the
superclass (a'la Feature class hierarchy) instead of listing them
explicitly.

2. Arm documentation now correctly lists values this property can take.

At the moment we support microRNA (Bio::EnsEMBL::MicroRNA) and generic
RNA product (Bio::EnsEMBL::RNAProduct). Any other type value will
trigger an exception.

A minimal extension of Bio::EnsEMBL::RNAProduct, with the only new
information being the arm of the hairpin the miRNA has come from. On the
storage side, this information is stored as a new type of rnaproduct
attribute.

The optional argument allows the user to only retrieve RNA products of
specific type, e.g. microRNAs. At the moment the type has to be
specified by a numerical ID, in the future this will be changed to allow
the passing of string codes.

In this particular case we *do* very much want to pass the argument
array to the proper method as it is, both in order to minimise the
overhead of aliases and just in case someone decides in the end to e.g.
to take advantage of direct modification of @_ contents in
get_all_DBEntries().

Thanks, perlcritic.

Needs some extra code in DBEntryAdaptor to actually work.

The former does not work yet because it needs extra code in DBEntryAdaptor.

The former does not work yet because it needs extra code in
AttributeAdaptor.