ZMap Issues

This is a record of stuff that we want not to forget in case we want to look at again and make sure it's been properly resolved.

1. In zmapbccol.c at line 286 was a call to bumpItem(), but sometimes the bc->bump it passes as first parameter is null. bumpItem is a macro that executes (w1/bump.c) bumpAdd and it is here that the code segfaults when bc->bump is null.

   #define bumpItem(_b,_w,_h,_px,_py) bumpAdd(_b,_w,_h,_px,_py,TRUE)
   

   BOOL bumpAdd (BUMP bump, int wid, float height, 
   	      int *px, float *py, BOOL doIt)
        /* works by resetting x, y */
   {
     int i, j ;
     int x = *px ;
     float ynew, y = *py ;
   
     if (bump->magic != &BUMP_MAGIC)
       messcrash ("bumpAdd received corrupt bump->magic");
      

   For now, I've put in if(bc->bump) but that might not be right.

   	    if (bc->bump)
   	      bumpItem(bc->bump, 1, seg->x2 - seg->x1, &xoff, &y);
      

2. There is no No 2.