PR review cleanups

parent 437fa802
Pipeline #104128 failed with stages
in 2 minutes and 56 seconds
......@@ -20,8 +20,6 @@ import classNames from 'classnames';
import find from 'lodash/find';
import { push } from 'connected-react-router';
import Tooltip from 'src/shared/components/tooltip/Tooltip';
import InlineSVG from 'src/shared/components/inline-svg/InlineSvg';
import analyticsTracking from 'src/services/analytics-service';
import useHover from 'src/shared/hooks/useHover';
import * as urlFor from 'src/shared/helpers/urlHelper';
......@@ -36,6 +34,9 @@ import {
} from 'src/content/app/species-selector/state/speciesSelectorSelectors';
import { getSpeciesAnalyticsName } from 'src/content/app/species-selector/speciesSelectorHelper';
import Tooltip from 'src/shared/components/tooltip/Tooltip';
import InlineSVG from 'src/shared/components/inline-svg/InlineSvg';
import { RootState } from 'src/store';
import {
CommittedItem,
......@@ -82,7 +83,7 @@ export const PopularSpeciesButton = (props: Props) => {
});
} else if (isCommitted) {
props.push(
urlFor.speciesHomepage({
urlFor.speciesPage({
genomeId: species.genome_id
})
);
......
......@@ -31,14 +31,14 @@ type EntityViewerUrlParams = {
view?: string | null;
};
type SpeciesHomepage = {
type SpeciesPageUrlParams = {
genomeId: string;
};
export const speciesHomepage = (params: SpeciesHomepage) => {
const speciesHomepageRootPath = '/species';
export const speciesPage = (params: SpeciesPageUrlParams) => {
const speciesPageRootPath = '/species';
return `${speciesHomepageRootPath}/${params.genomeId}`;
return `${speciesPageRootPath}/${params.genomeId}`;
};
export const browser = (params?: BrowserUrlParams) => {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment