Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
E
ensembl-client
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
0
Merge Requests
0
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Package Registry
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
ensembl-web
ensembl-client
Commits
1a345d4b
Commit
1a345d4b
authored
Oct 20, 2020
by
Manoj Pandian Sakthivel
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
PR review cleanups
parent
437fa802
Pipeline
#104128
failed with stages
in 2 minutes and 56 seconds
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
7 deletions
+8
-7
src/ensembl/src/content/app/species-selector/components/popular-species-button/PopularSpeciesButton.tsx
...omponents/popular-species-button/PopularSpeciesButton.tsx
+4
-3
src/ensembl/src/shared/helpers/urlHelper.ts
src/ensembl/src/shared/helpers/urlHelper.ts
+4
-4
No files found.
src/ensembl/src/content/app/species-selector/components/popular-species-button/PopularSpeciesButton.tsx
View file @
1a345d4b
...
...
@@ -20,8 +20,6 @@ import classNames from 'classnames';
import
find
from
'
lodash/find
'
;
import
{
push
}
from
'
connected-react-router
'
;
import
Tooltip
from
'
src/shared/components/tooltip/Tooltip
'
;
import
InlineSVG
from
'
src/shared/components/inline-svg/InlineSvg
'
;
import
analyticsTracking
from
'
src/services/analytics-service
'
;
import
useHover
from
'
src/shared/hooks/useHover
'
;
import
*
as
urlFor
from
'
src/shared/helpers/urlHelper
'
;
...
...
@@ -36,6 +34,9 @@ import {
}
from
'
src/content/app/species-selector/state/speciesSelectorSelectors
'
;
import
{
getSpeciesAnalyticsName
}
from
'
src/content/app/species-selector/speciesSelectorHelper
'
;
import
Tooltip
from
'
src/shared/components/tooltip/Tooltip
'
;
import
InlineSVG
from
'
src/shared/components/inline-svg/InlineSvg
'
;
import
{
RootState
}
from
'
src/store
'
;
import
{
CommittedItem
,
...
...
@@ -82,7 +83,7 @@ export const PopularSpeciesButton = (props: Props) => {
});
}
else
if
(
isCommitted
)
{
props
.
push
(
urlFor
.
species
Homep
age
({
urlFor
.
species
P
age
({
genomeId
:
species
.
genome_id
})
);
...
...
src/ensembl/src/shared/helpers/urlHelper.ts
View file @
1a345d4b
...
...
@@ -31,14 +31,14 @@ type EntityViewerUrlParams = {
view
?:
string
|
null
;
};
type
Species
Homepage
=
{
type
Species
PageUrlParams
=
{
genomeId
:
string
;
};
export
const
species
Homepage
=
(
params
:
SpeciesHomepage
)
=>
{
const
species
Homep
ageRootPath
=
'
/species
'
;
export
const
species
Page
=
(
params
:
SpeciesPageUrlParams
)
=>
{
const
species
P
ageRootPath
=
'
/species
'
;
return
`
${
species
Homep
ageRootPath
}
/
${
params
.
genomeId
}
`
;
return
`
${
species
P
ageRootPath
}
/
${
params
.
genomeId
}
`
;
};
export
const
browser
=
(
params
?:
BrowserUrlParams
)
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment