Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
ensembl-web
ensembl-client
Commits
81bc53f9
Unverified
Commit
81bc53f9
authored
Sep 01, 2021
by
Imran Salam
Committed by
GitHub
Sep 01, 2021
Browse files
Fix invalid query param breaking Entity Viewer (#564)
parent
1967b77f
Pipeline
#189617
passed with stages
in 8 minutes and 58 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
1 deletion
+4
-1
src/ensembl/src/content/app/entity-viewer/gene-view/GeneView.tsx
...embl/src/content/app/entity-viewer/gene-view/GeneView.tsx
+4
-1
No files found.
src/ensembl/src/content/app/entity-viewer/gene-view/GeneView.tsx
View file @
81bc53f9
...
...
@@ -345,6 +345,9 @@ const GeneViewWithData = (props: GeneViewWithDataProps) => {
);
};
const
isViewParameterValid
=
(
view
:
string
)
=>
Object
.
values
(
View
).
some
((
value
)
=>
value
===
view
);
const
useGeneViewRouting
=
()
=>
{
const
dispatch
=
useDispatch
();
const
params
:
{
[
key
:
string
]:
string
}
=
useParams
();
...
...
@@ -361,7 +364,7 @@ const useGeneViewRouting = () => {
const
selectedTabs
=
useSelector
(
getSelectedGeneViewTabs
);
useEffect
(()
=>
{
if
(
view
&&
viewInRedux
!==
view
)
{
if
(
view
&&
isViewParameterValid
(
view
)
&&
viewInRedux
!==
view
)
{
dispatch
(
updateView
(
view
as
View
));
}
else
{
const
url
=
urlFor
.
entityViewer
({
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment