Unverified Commit b7872a7c authored by Dan Sheppard's avatar Dan Sheppard Committed by GitHub
Browse files

Revert to using scheduler groups from timers (performance fix) (#209)

An earlier commit changed the means by which callbacks are registered to the scheduler. This was anticipated to have negligible effect, but was otherwise poorly motivated. As a result, the change had already been reverted on the active dev branch when it was later found that the change had a significant (well-characterised but poorly-understood) performance impact. Unfortunately, between the change and its reversion, the code got pushed to dev and live. The active dev branch for this code is not yet ready for merge, and the effect of this change being live  is noticeable. So this bugfix commit pushes the reversion (only) to dev.
parent 01e7370f
Pipeline #46593 passed with stages
in 9 minutes and 14 seconds
......@@ -163,14 +163,16 @@ impl AppRunner {
}
}),5,false);
}
/* animate & draw */
let app = imp.app.clone();
imp.sched_group.add("draw",Box::new(move |_| {
let t = browser_time();
let mut imp = app.lock().unwrap();
let actions = imp.get_window().get_animator().tick(t);
imp.run_actions(&actions,None);
imp.draw();
}),0,true);
}
/* draw */
self.add_timer("draw",move |app,t,_| {
let actions = app.get_window().get_animator().tick(t);
app.run_actions(&actions,None);
app.draw();
vec![]
},0);
/* xfer */
self.add_timer("xfer",move |app,_,sr| {
if !app.tick_xfer() {
......
......@@ -7633,8 +7633,8 @@
}
},
"ensembl-genome-browser": {
"version": "https://raw.githubusercontent.com/Ensembl/ensembl-genome-browser-assets/master/assets-2f05824d6824bc29771e17a63cbddf09.tar.gz",
"integrity": "sha512-RzL5NIYWTv8yuyJSKxKNvJD0BBSBMMXMVVUtGIiNovS4ynvs+ApkMnKXVMyz+CIMvE9HjNEsWdpSwgQJVzTyzw=="
"version": "https://raw.githubusercontent.com/Ensembl/ensembl-genome-browser-assets/master/assets-80f51620ed443c640cdfd6b5aebd505b.tar.gz",
"integrity": "sha512-fuO1rOCEGNZHZcv4Ft36PKnzxtYZ8V4C2sMZyq52uhSv4wQtgFOR/sDgFCzn+fLL78de3CSvTMpTttC3TRw5ew=="
},
"entities": {
"version": "1.1.2",
......
......@@ -54,7 +54,7 @@
"connected-react-router": "6.5.2",
"core-js": "3.4.1",
"dotenv": "8.2.0",
"ensembl-genome-browser": "https://raw.githubusercontent.com/Ensembl/ensembl-genome-browser-assets/master/assets-2f05824d6824bc29771e17a63cbddf09.tar.gz",
"ensembl-genome-browser": "https://raw.githubusercontent.com/Ensembl/ensembl-genome-browser-assets/master/assets-80f51620ed443c640cdfd6b5aebd505b.tar.gz",
"koa-proxy": "1.0.0-alpha.3",
"lodash": "4.17.15",
"query-string": "6.9.0",
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment