Kamal Dodiya (e1cef18b) at 25 Mar 14:26
Merge branch 'migration-agent' into 'master'
... and 1 more commit
Kamal Dodiya (2597f53b) at 25 Mar 14:26
This PR is to migrate k8s integration to agent based integration for deploying to k8s cluster. The task is to migrate whatever we have now as it is without adding additional functionality.
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-2495
None
Gitlab Agent : https://docs.gitlab.com/ee/user/clusters/agent/
YAML Anchors: https://docs.gitlab.com/ee/ci/yaml/yaml_optimization.html
Pipeline with example showing the dev context https://gitlab.ebi.ac.uk/ensembl-web/ensembl_search_hub/-/pipelines/504135
None
This PR is to migrate k8s integration to agent based integration for deploying to k8s cluster. The task is to migrate whatever we have now as it is without adding additional functionality.
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-2495
None
Gitlab Agent : https://docs.gitlab.com/ee/user/clusters/agent/
YAML Anchors: https://docs.gitlab.com/ee/ci/yaml/yaml_optimization.html
Pipeline with example showing the dev context https://gitlab.ebi.ac.uk/ensembl-web/ensembl_search_hub/-/pipelines/504135
None
This PR is to migrate k8s integration to agent based integration for deploying to k8s cluster. The task is to migrate whatever we have now as it is without adding additional functionality.
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-2495
None
Gitlab Agent : https://docs.gitlab.com/ee/user/clusters/agent/
YAML Anchors: https://docs.gitlab.com/ee/ci/yaml/yaml_optimization.html
Pipeline with example showing the dev context https://gitlab.ebi.ac.uk/ensembl-web/ensembl_search_hub/-/pipelines/504135
None
@andres Yes, Agree. We will have to make it consistent across all the API but I would rather do it in the separate PR than here. I will add this to the list of Backend Priority. Also, its fair to say that if we plan to move to GitOps or something entire deploy section would be irrelevant. That is why I suggested its a good thing but needs its own dedicated task/discission. Thanks
Self-reply: Here's the deployment job in the example pipeline.
This PR is to migrate k8s integration to agent based integration for deploying to k8s cluster. The task is to migrate whatever we have now as it is without adding additional functionality.
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-2495
None
Gitlab Agent : https://docs.gitlab.com/ee/user/clusters/agent/
YAML Anchors: https://docs.gitlab.com/ee/ci/yaml/yaml_optimization.html
Pipeline with example showing the dev context https://gitlab.ebi.ac.uk/ensembl-web/ensembl_search_hub/-/pipelines/504135
None
I commented on this code part because it was not clear to me what and why was done here. You can add branch rules with extends (see example here) which is clearer and recommended approach.
I'll approve this MR but please consider switching to extends array (see the first comment in this thread).
The extends is extending deploy template. which largely remains as it is across different. With YAML anchors you can have additional conditions. Say for staging we want to deploy from dev branch ( I know here it is not the case). Or for review we want to add branching rules.
So Its composition of multiple things with extends you will have to well defined template. You can achieve same thing with extends but then you will need to have multilevel extends.
Again purpose of this PR is to have agent based integration.
The above recommends using the extends
array over yaml magic chars. Here is combination of both. Is it itentional?
The pipeline uses code not included in this MR. Can you add a link to that code?
See this test pipeline https://gitlab.ebi.ac.uk/ensembl-web/ensembl_search_hub/-/pipelines/504135
I think this should be in separate PR. The purpose here is to migrate k8s integration to use gitlab agent. Setting up review in itself is a topic which will need wider discussion and come up with strategy how do we want to deploy review branches.
Kamal Dodiya (2e4f436f) at 22 Mar 09:22
Fix pipeline
Kamal Dodiya (2b3c3bc3) at 22 Mar 09:21
Test
Kamal Dodiya (2597f53b) at 22 Mar 09:20
Migrate to agent based k8s integration
Kamal Dodiya (0eef848f) at 22 Mar 09:20
Kamal Dodiya (0eef848f) at 22 Mar 09:16