html-sites issueshttps://gitlab.ebi.ac.uk/groups/emblorg/html-sites/-/issues2021-09-15T07:43:33Zhttps://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/issues/10Get Google Analytics working2021-09-15T07:43:33ZKen Hawkinsken.hawkins@embl.deGet Google Analytics workingAlthough GA tracking code [is present](https://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/blob/master/public/index.html#L76-86), it is not logging page views.
One popular react-based method is `react-ga`:
- https://github.co...Although GA tracking code [is present](https://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/blob/master/public/index.html#L76-86), it is not logging page views.
One popular react-based method is `react-ga`:
- https://github.com/react-ga/react-ga
- https://www.npmjs.com/package/react-ga
- https://medium.com/geekculture/how-to-use-google-analytics-on-reactjs-in-5-minutes-7f6b43017ba9
![image](/uploads/6ae776ca9b41c61c6869c1b0d552cd66/image.png)Nitin JadhavNitin Jadhavhttps://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/issues/9EMBO filter showing EMBL jobs2021-09-08T13:48:48ZKen Hawkinsken.hawkins@embl.deEMBO filter showing EMBL jobsWhen the EMBO filter is selected it also shows jobs at all EMBL sites.
![image](/uploads/a1986c52b447c626246fa9692ca910ab/image.png)
---
Email from HR
> From: Bettina Trueb <bettina.trueb@embo.org>
> Sent: Tuesday, 7 September 2021...When the EMBO filter is selected it also shows jobs at all EMBL sites.
![image](/uploads/a1986c52b447c626246fa9692ca910ab/image.png)
---
Email from HR
> From: Bettina Trueb <bettina.trueb@embo.org>
> Sent: Tuesday, 7 September 2021 09:21
> To: Lenka Stejskal <lenka.stejskal@embl.de>
> Subject: EMBO jobs on the EMBL website
>
> Hi Lenka,
>
> Thanks for posting our new VNs.
> The new website and filtering system is really great! It’s super practical to be able to filter the positions by site and type like that. I only noticed that for some reason there are several non-EMBO positions showing up under EMBO on the website. I’m attaching a screenshot.
> Could you look into what is causing this please? It seems a little misleading and I wonder if people would miss these ads because they’re shown in the wrong place.
>
> Thanks,
> BettinaNitin JadhavNitin Jadhavhttps://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/issues/8Job date inconsistencies2021-09-15T15:13:49ZFilipe DiasJob date inconsistenciesHi Nitin
The date of a job post is shown inconsistently between browsers and follows different formats. If I use firefox (latest) or Brave (chromium based) the date is shown as month (spelled), day, year. If using Waterfox (custom LTS F...Hi Nitin
The date of a job post is shown inconsistently between browsers and follows different formats. If I use firefox (latest) or Brave (chromium based) the date is shown as month (spelled), day, year. If using Waterfox (custom LTS Firefox) the date is shown using slashes as day/month/year.
<details><summary>See screenshot</summary>
![normal-date-jobs](/uploads/44ffcddf19278dffbba16bf5dc91bcf4/normal-date-jobs.png)
</details>
On Spilios' mac, using his firefox it is shown in slashes but in the american format, month/day/year:
<details><summary>See screenshot</summary>
![american-date-jobs](/uploads/2682e4a34abecde3e7417001fd598beb/american-date-jobs.png)
</details>
Can you investigate why the different results are displayed? Especially important is not to show numerical dates in the american format.
ThanksNitin JadhavNitin Jadhavhttps://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/issues/7Job alert redirects2021-06-16T07:45:29ZKen Hawkinsken.hawkins@embl.deJob alert redirects@nitin When email notifications come in, they go to redirect URL like this.
These don't seem to work on the new react version. Not sure if you already attempted to fix this?
- 11ty: https://www.embl.org/jobs/alerts/alert-email/4080/?r...@nitin When email notifications come in, they go to redirect URL like this.
These don't seem to work on the new react version. Not sure if you already attempted to fix this?
- 11ty: https://www.embl.org/jobs/alerts/alert-email/4080/?redirected_from_emblde_jobs=true
- react: https://wwwdev.embl.org/jobs/alerts/alert-email/4080/?redirected_from_emblde_jobs=trueNitin JadhavNitin Jadhavhttps://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/issues/6Job alerts form - looks incorrect2021-05-14T12:29:02ZStuart RobsonJob alerts form - looks incorrectthis is because the markup isn't following the Visual Framework
live:
![Screenshot_2021-05-14_at_13.24.04](/uploads/d4ebdcd4cc74d6dc2f090ae6430f2a37/Screenshot_2021-05-14_at_13.24.04.png)
visual framework:
![Screenshot_2021-05-14_at_...this is because the markup isn't following the Visual Framework
live:
![Screenshot_2021-05-14_at_13.24.04](/uploads/d4ebdcd4cc74d6dc2f090ae6430f2a37/Screenshot_2021-05-14_at_13.24.04.png)
visual framework:
![Screenshot_2021-05-14_at_13.25.41](/uploads/287b6c1641ece3d9e50dc9f2d0aa5a14/Screenshot_2021-05-14_at_13.25.41.png)
note the spacing between items.https://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/issues/5spacing of 'number of results'2021-06-18T11:58:36ZStuart Robsonspacing of 'number of results'@khawkins-embl shouldn't 'Type' also have the space between the item name and number?
![Screenshot_2021-05-14_at_13.01.26](/uploads/acf7734a5609ba2b949d5a94b1ece26e/Screenshot_2021-05-14_at_13.01.26.png)@khawkins-embl shouldn't 'Type' also have the space between the item name and number?
![Screenshot_2021-05-14_at_13.01.26](/uploads/acf7734a5609ba2b949d5a94b1ece26e/Screenshot_2021-05-14_at_13.01.26.png)https://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/issues/4layout issue on job post2021-05-14T12:40:16ZStuart Robsonlayout issue on job post![Screenshot_2021-05-14_at_12.52.52](/uploads/1f430d6839b8c931ae9a1fd5b77528c9/Screenshot_2021-05-14_at_12.52.52.png)
browser details for reference - whatismybrowser.com/w/BKG4GZM![Screenshot_2021-05-14_at_12.52.52](/uploads/1f430d6839b8c931ae9a1fd5b77528c9/Screenshot_2021-05-14_at_12.52.52.png)
browser details for reference - whatismybrowser.com/w/BKG4GZMhttps://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/issues/3incorrect font size on job location2021-05-14T12:44:26ZStuart Robsonincorrect font size on job locationAs of this issue being posted:
On the current `www` for EMBL jobs the location is set at 16px because it span inside the `vf-summary__meta`.
The update on `wwwdev` changes this and wraps the location in a `p` tag. Because somewhere fur...As of this issue being posted:
On the current `www` for EMBL jobs the location is set at 16px because it span inside the `vf-summary__meta`.
The update on `wwwdev` changes this and wraps the location in a `p` tag. Because somewhere further up the DOM tree there is the `vf-content` class -- the location like - "EMBL Heidelberg" or "EMBL-EBI Hinxton" inherit the CSS for a `p` tag without a class inside of `vf-content`.
Here's the before and after screenshots and HTML
Before:
```
<p class="vf-summary__meta"> Staff Member in <span class="jplist-duty-station">EMBL-EBI Hinxton</span></p>
```
![Screenshot_2021-05-14_at_11.43.16](/uploads/9bf85203313d83e6e456c2e0b55c842c/Screenshot_2021-05-14_at_11.43.16.png)
After:
```
<p class="vf-summary__meta">Staff Member in <span class="jplist-duty-station"><p>EMBL-EBI Hinxton</p></span></p>
```
![Screenshot_2021-05-14_at_11.45.01](/uploads/aa0c17f04fef2f8ff9ff69aebe673e9e/Screenshot_2021-05-14_at_11.45.01.png)https://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/issues/2recent updates - jobs home page performance2021-05-14T12:16:35ZStuart Robsonrecent updates - jobs home page performanceJust to note that the recent changes have impacted the page speed performance and overall file size of the jobs page.
As of yesterday:
the file size for `wwwdev` was 1.2mb compared to 590kb on `www`. So recent changes have almost dou...Just to note that the recent changes have impacted the page speed performance and overall file size of the jobs page.
As of yesterday:
the file size for `wwwdev` was 1.2mb compared to 590kb on `www`. So recent changes have almost doubled the overall file size.
On a slow 3g connection the time it takes to load the entire page has gone from 14 seconds on `www` to 26.3 seconds on `wwwdev`.
On a fast 3g connection the time it takes to load the entire page has gone from 4 seconds on `www` to 7.5 seconds` on `wwwdev`.
---
So doubling the file size and adding more work on the client side has also doubled the time it takes for the page to load.
Note: the page speed wasn't great to start with -- it's worse now.https://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/issues/1GitLab objecting to container_scanning2020-10-06T07:12:36ZKen Hawkinsken.hawkins@embl.deGitLab objecting to container_scanning@sandeep For some reason gitlab started objecting to the CI container_scanning attribute.
https://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/pipelines/90364
```
Found errors in your .gitlab-ci.yml:
jobs:container_scanning co...@sandeep For some reason gitlab started objecting to the CI container_scanning attribute.
https://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/pipelines/90364
```
Found errors in your .gitlab-ci.yml:
jobs:container_scanning config key may not be used with `rules`: only
You can also test your .gitlab-ci.yml in CI Lint
```
Reading the docs, this is a false error. I've temporarily disabled it to continue development:
https://gitlab.ebi.ac.uk/emblorg/html-sites/embl-jobs-pages/-/commit/5dbef805e3ad231cc1bc56edf19ef91aa1772a07Sandeep KadamSandeep Kadam