From cb1a18f98c6904efb0c2db241d66bc121612fba7 Mon Sep 17 00:00:00 2001
From: Nikos Marinos <nmarinos@ebi.ac.uk>
Date: Fri, 8 Mar 2019 17:45:17 +0000
Subject: [PATCH] Addresses #416

---
 server/ncbi-integration/publishedCheck.js                 | 8 ++++++++
 .../xpub-model/entities/manuscript/helpers/transform.js   | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/server/ncbi-integration/publishedCheck.js b/server/ncbi-integration/publishedCheck.js
index e7b3df480..49345d3d6 100644
--- a/server/ncbi-integration/publishedCheck.js
+++ b/server/ncbi-integration/publishedCheck.js
@@ -29,6 +29,9 @@ async function publishedCheck() {
       const manuscript4Db = new Manuscript(manuscript)
       delete manuscript4Db.users
       await manuscript4Db.save()
+      logger.info(
+        `Status of manuscript ${manuscript.id} was changed to 'published'`,
+      )
       sendEmails(manuscript)
     }
   }
@@ -88,6 +91,11 @@ function sendEmails(manuscript) {
       user.identities
         .filter(identity => !identity.deleted)
         .forEach(identity => {
+          logger.info(
+            `Emailing ${identity.email} about their published manuscript ${
+              manuscript.id
+            }.`,
+          )
           manuscriptHasBeenPublishedEmail(
             identity.email,
             `PMC${pmcid}: ${manuscript['meta,title']}`,
diff --git a/server/xpub-model/entities/manuscript/helpers/transform.js b/server/xpub-model/entities/manuscript/helpers/transform.js
index 04398707e..454988520 100644
--- a/server/xpub-model/entities/manuscript/helpers/transform.js
+++ b/server/xpub-model/entities/manuscript/helpers/transform.js
@@ -58,7 +58,7 @@ const gTeams = model =>
 
 // Transform from Database model to GraphQL data
 const gManuscript = model => {
-  const keys = Object.keys(model)
+  const keys = Object.keys(model).filter(key => model[key])
   const manuscript = {}
   manuscript.meta = {}
   keys.forEach(k => {
-- 
GitLab