bugfix: Since version 3.8.0 DBD::Pg returns the database name in TABLE_CAT (!103) · Merge requests · ensembl-gh-mirror / ensembl-hive

Created by: muffato

Use case

The daily Travis builds have been failing on PostgreSQL for a few days. This is because of a change in DBD::Pg version 3.8.0 released a few days ago: https://metacpan.org/changes/distribution/DBD-Pg (commits https://github.com/bucardo/dbdpg/commit/527fd30d2335b15d1d023dc52e1dae0b1deb71ec and https://github.com/bucardo/dbdpg/commit/a86442432e3a4322aa3ad04d3cdca6aa44a67927 ) The column_info structure now includes the database name in the TABLE_CAT field (instead of undef before). Since the test creates two different databases (travis_ehive_test_old_patched vs travis_ehive_test_new) on the same server and compares their schema, it is now failing.

Just discard the TABLE_CAT field from the comparison

None envisaged

Have you added/modified unit tests to test the changes?

Not needed. The change actually fixes an existing test

If so, do the tests pass/fail?

Yes

Have you run the entire test suite and no regression was detected?

Yes