Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl-hive
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl-hive
  • Merge requests
  • !121

Exclude "/" from pipeline names too as it causes problems in URLs

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marek Szuba requested to merge experimental/no_slash_in_pipeline_name into version/2.4 Jul 02, 2019
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: muffato

Use case

Jorge found this one by accident. He had put a / in the pipeline_name option and then generate_graph.pl failed with this error Error: <stdin>: syntax error in line 119 near '/'

When doing my own tests, I realized that the URLs themselves would be confusing with a / in the database name, so better to remove them early on.

Description

Just like whitespace, replace the / with an underscore

Possible Drawbacks

N/A

Testing

Have you added/modified unit tests to test the changes?

No, that function is not currently tested.

If so, do the tests pass/fail?

Have you run the entire test suite and no regression was detected?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: experimental/no_slash_in_pipeline_name