Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl-hive
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl-hive
  • Merge requests
  • !127

readability fixes

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marek Szuba requested to merge bugfix/amend_guest_standalone_job into version/2.5 Jul 09, 2019
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: ens-bwalts

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the development guidelines for eHive; remember in particular:
    • Do not modify code without testing for regression.
    • Provide simple unit tests to test the changes.
    • If you change the database schema, please follow the instructions for schema changes in the developer guidelines.
    • If you change the schema, meadow, or guest language interfaces, please follow the scheme for internal versioning in the developer guidelines.
    • The PR must not fail unit testing.

Use case

@mkszuba noted that we have an opportunity to make some readability fixes with the changes brought in with #108. We should make these fixes in 2.5 as well, as long as we're making them - we get a slightly cleaner commit history this way, too.

Description

Added whitespace where it will add clarity, in lines that were new or being changed anyway.

Possible Drawbacks

Authorship of functional change is one commit off on a couple of lines

Testing

Have you added/modified unit tests to test the changes? N/A If so, do the tests pass/fail? N/A Have you run the entire test suite and no regression was detected? Yes

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bugfix/amend_guest_standalone_job