Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
E
ensembl-hive
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge Requests 7
    • Merge Requests 7
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ensembl-gh-mirror
  • ensembl-hive
  • Merge Requests
  • !140

Open
Opened Aug 21, 2019 by Marek Szuba@mksOwner
  • Report abuse
Report abuse

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "experimental/require_valid_registry_file" "origin/experimental/require_valid_registry_file"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "master"
git merge --no-ff "experimental/require_valid_registry_file"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Throw if the requested registry file doesn't exist

  • Overview 0
  • Commits 5
  • Changes 3

Created by: muffato

Use case

When a worker or beekeeper is invoked with a wrong reg_conf argument, there is no explicit warning / error message, only potentially an error about the reg_alias not being found in the Registry.

Description

Registry::load_all already has a flag to require the file to exist. I merely enable it and we now get a much clearer error message.

Possible Drawbacks

This is a breaking change for people who use a url and an invalid reg_conf at the same time. Previously, there would have been no warnings about the invalid reg_conf, and the database would have been connected to via its URL. Now eHive is going to complain about the reg_conf,

Testing

Have you added/modified unit tests to test the changes?

Yes, but requires Ensembl/ensembl#408

If so, do the tests pass/fail?

Yes

Have you run the entire test suite and no regression was detected?

Yes

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: ensembl-gh-mirror/ensembl-hive!140
Source branch: experimental/require_valid_registry_file