Skip to content

Misc. bugfixes in tweak_pipeline.pl

Marek Szuba requested to merge experimental/tweak_pipeline_bugfixes into version/2.4

Created by: muffato

Use case

Here are two bugs that I've identified whilst reviewing #62

  1. The tweak query printed back to the user was showing the string meadow instead of the actual meadow type.
  2. The script allowed deleting non-existing pipeline-wide parameters, which was resulting in Perl warnings about undefined values etc

Description

  1. Print the variable $meadow_type instead
  2. This had been fixed on 2.5 but not backported. I simply cherry-picked the commit

Possible Drawbacks

Once this is accepted and merged on the later branches, @mira13 will have to rebase her changes (#62) which may conflict. But it will make her changeset clearer.

Testing

Have you added/modified unit tests to test the changes?

No, there are currently no tests for tweak_pipeline.pl

If so, do the tests pass/fail?

N/A

Have you run the entire test suite and no regression was detected?

Yes, all fine

Merge request reports