Skip to content

For maintainability use the list of statuses defined in AnalysisJobAdaptor

Marek Szuba requested to merge experimental/queen_list_job_status into master

Created by: muffato

Requirements

Use case

I had missed this occurrence when I introduced the variable in 1d3cab12 The goal was to minimize the number of places with an hardcoded list of statuses so that most of the code will still work if somehow the list is changed

Description

Import the module and use the variable

Possible Drawbacks

None I can think of

Testing

Have you added/modified unit tests to test the changes?

No, there is currently no test for runWorker.pl --job_id. Should I add one ? I can maybe add this to t/03.scripts/beekeeper_reset.t:

  1. Try running a worker on the job_id of a READY job. It should return 0 and the job will be DONE
  2. Try running a worker on the same job_id. It should return !=0 because the job is DONE. when_completed should not change
  3. Try running a worker on the same job_id but with --force. It should accept it and when_completed will change

If so, do the tests pass/fail?

Have you run the entire test suite and no regression was detected?

All fine

Merge request reports