Created by: muffato
I've found this whilst working on a fix for negative job counts.
$self-> is missing here, which makes this line a function call, not a method call. The subroutine then gets
$self and the other arguments (it expects
$has_refresh_just_been_done) are both undefined.
Because it can deal with undefined
$stats and returns immediately, it's never raised an error, but this means this call was doing nothing.
I guess this only means that failures were not reported with the freshest stats, which people may not even notice.
Have you added/modified unit tests to test the changes?
If so, do the tests pass/fail?
Have you run the entire test suite and no regression was detected?