Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
E
ensembl-otter
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge Requests 3
    • Merge Requests 3
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ensembl-gh-mirror
  • ensembl-otter
  • Merge Requests
  • !118

Open
Opened Jul 01, 2020 by Marek Szuba@mksOwner
  • Report abuse
Report abuse

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "make_attributes_persistent" "origin/make_attributes_persistent"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "test_server_client"
git merge --no-ff "make_attributes_persistent"

Step 4. Push the result of the merge to GitLab

git push origin "test_server_client"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Make attributes persistent

  • Overview 0
  • Commits 41
  • Changes 12

Created by: s-mm

This PR combines changes required to resolve ENSCORESW-3411 and ENSCORESW-3390.

  1. ENSCORESW-3411 Author changed for any transcript in an edited locus for the following reasons
  • Missing attributes

  • Difference in number of the same attribute

  • Difference in letter case for vega hashkey for transcript

  • Trailing white space in vega hashkey

  • Difference in status of biotypes

Similar reasons were observed for author changes at gene level.

  1. ENSCORESW-3390 When a gene/transcript is edited, only few attributes are added to gene_attrib/transcript_attrib table. It does not add attributes like 'vega_name', 'TAGENE_transcript', 'MANE_Select', 'ccds_transcript', 'miRNA', 'ncRNA', 'Frameshift'. Whenever a locus is edited, the code checks if these attributes are present. As these attributes are not added to gene_attrib/transcript_attrib table, the code assumes the gene/transcript has been edited even when it has not been edited.

'vega_name', 'TAGENE_transcript', 'MANE_Select', 'ccds_transcript', 'miRNA', 'ncRNA', 'Frameshift' is set for transcripts. 'vega_name' is set for genes.

Note:

  • upstream_ATG, parent_exon_key, parent_sid attributes have not been handled. This is due to lack of testing.

  • Author changes have been noticed for transcripts due to change in status for few biotypes (miRNA, ncRNA). Author changes have been noticed for genes as the code sets the 'name' attribute for these genes. This has been noticed for genes that were introduced in the DB as part of the NoMerge process.

  • Random author changes have been noticed for ENSE and ENSP. This is due to change in vega_hashkey.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: ensembl-gh-mirror/ensembl-otter!118
Source branch: make_attributes_persistent