Skip to content

Depend on modules used by built-in YAML and HTML serialisers

Marek Szuba requested to merge ENSCORESW-2709 into master

Created by: mkszuba

Description

Add YAML::XS, YAML::Syck and URI::Find to the cpanfile as required modules.

Use case

These three modules are required for the YAML (the former) and HTML (the latter two) serialisers provided by Catalyst::Controller::REST to work. The latter is especially important because it has been configured in our server as the fallback serialiser for unknown content types, which in our case includes e.g. text/x-fasta; its presence is therefore necessary for erroneous requests for our special content types (such as requesting a sequence for an unknown transcript stable ID) to return the actual error message, e.g.

{"error":"ID 'ENSTdeadbeef' not found"}

(the content type of error responses to requests involving content types handled by the fallback serialiser is 'application/json') instead of the generic (and pretty much useless)

Content-Type text/html is not supported.

Benefits

Prevents the REST server from swallowing errors on special content types. See also: https://www.ebi.ac.uk/panda/jira/browse/ENSCORESW-2709 .

Possible Drawbacks

Slightly increased installation size.

Testing

Have you added/modified unit tests to test the changes?

N/A

Merge request reports