Skip to content

Feature/fix strain info

Marek Szuba requested to merge feature/fix_strain_info into master

Created by: nerdstrike

Description

The addition of a default division to the species/info endpoint (EnsemblVertebrates) has exposed a bug in the Model::Registry->get_species_info, which was made without the expectation of divisions for everything

Use case

Strains hidden for vertebrates so that users are not surprised with new seemingly unimportant keys in the returned documents.

Benefits

Code is cleaner, works as intended, and is able to filter on division AND strain collection, not one or the other.

Possible Drawbacks

None obvious

Testing

Testing environment required more specific hacks for BioPerl versions to protect Bio::DB::HTS. Tests are otherwise unchanged outside of some whitespace.

If so, do the tests pass/fail?

Pass

Have you run the entire test suite and no regression was detected? Indeed

Changelog

Not relevant to users.

Merge request reports