Skip to content

Changes needed to support the use of release branches in Travis builds

Marek Szuba requested to merge travis_hdf5_branch into master

Created by: mkszuba

Description

Two changes:

  • have the cloning of ensembl-hdf5 honour the value of $ENSEMBL_BRANCH instead of always using the master branch,
  • quote the value of $ENSEMBL_BRANCH to future-proof ourselves against funky branch names and broken shells.

Use case

Core release procedures have just been updated so that ensembl-rest Travis builds on release branches use corresponding release branches in other Ensembl repositories instead of master. Right now implementing this required the branch-name changes in two places, and with variable values being unquoted there is potential for getting something wrong.

Benefits

Release-branch builds of ensembl-rest will only require a change in one place with respect to master to make sure all Ensembl dependencies use the correct release branch, and always quoting the branch name means it won't be necessary for whoever branches ensembl-rest to think about whether they should introduce quotes upon changing the branch name or not.

Possible Drawbacks

None.

Testing

Have you added/modified unit tests to test the changes?

No.

If so, do the tests pass/fail?

N/A

Have you run the entire test suite and no regression was detected?

Change affects Travis only. The build on the pushed branch has not completed yet but with this being essentially #363 with the branch name changed back to master, problems are unlikely.

Changelog

Are you changing the functionality of an endpoint? If so, please give a one line summary for the public facing changelog.

Changes only affect the execution of tests on Travis, no endpoint-related changes of any sort have been involved.

Merge request reports