Skip to content

bugfix: not all users require a password

Marek Szuba requested to merge github/fork/muffato/master into master

Created by: muffato

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Use case

I am not able to run db-space.pl with the ensro user, and I'd prefer not using ensadmin unless really needed

Description

The script doesn't die any more if the password is not provided. It then only adds the -p option to the mysql command line if there is actually a password (-p alone makes mysql prompt for a password)

Benefits

I can call db-space.pl with the ensro to generate the disk usage reports

Possible Drawbacks

The error message for someone running the script with ensadmin and no password will be different (it will come from . I don't expect anyone to be relying on that

Testing

Have you added/modified unit tests to test the changes?

No, there were no tests on that script

If so, do the tests pass/fail?

N/A

Have you run the entire test suite and no regression was detected?

No.

Merge request reports