Skip to content

ENSCORESW-2695: expand methods for REST support

Marek Szuba requested to merge feature/biotype_methods into master

Created by: magaliruffier

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Description

New fetch_all_by_name method, used for REST endpoints.

Use case

Some REST endpoints retrieve information on biotypes by their names. The original implementation uses straight SQL queries. Replacement methods have now been implemented on the BiotypeAdaptor.

Benefits

Some direct SQL removed, makes it easier to protect the REST endpoints from schema changes.

Possible Drawbacks

Some scenarios might not be tested for

Testing

Have you added/modified unit tests to test the changes?

Yes. Added some tests in the biotype.t

If so, do the tests pass/fail?

Yes Have you run the entire test suite and no regression was detected?

Yes.

Merge request reports