Skip to content

ENSCORESW-2837: do not import dependent VGNC

Marek Szuba requested to merge feature/uniprot_dependent into master

Created by: magaliruffier

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Description

Using one or more sentences, describe in detail the proposed changes. Ignore VGNC xrefs in UniProt data as we already get the data elsewhere.

Use case

Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place. VGNC is imported directly from the VGNC website with curated links to Ensembl data. We want to avoid importing additional links via UniProt. The data will not be as up to date as getting the data directly from VGNC. Additionally, this means we would add links via a third-party source, meaning it is less accurate.

Benefits

If applicable, describe the advantages the changes will have. VGNC mappings are consistent and as up-to-date as possible

Possible Drawbacks

If applicable, describe any possible undesirable consequence of the changes. Coverage of VGNC mappings may decrease.

Testing

Have you added/modified unit tests to test the changes? This was run on cow, chimp, dog and horse, the 4 species with VGNC data.

If so, do the tests pass/fail? No changes noticed

Have you run the entire test suite and no regression was detected? NA

Merge request reports