Skip to content

ENSCORESW-2853: match Ensembl species casing

Marek Szuba requested to merge bugfix/reactome_species into master

Created by: magaliruffier

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Description

Using one or more sentences, describe in detail the proposed changes. Match species name between Reactome syntax and Ensembl syntax

Use case

Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place. Reactome write species names like Homo sapiens Ensembl write species name like homo_sapiens We want to match the Homo sapiens data to homo_sapiens, so need a reliable way to compare species names.

Benefits

If applicable, describe the advantages the changes will have. Reactome data is mapped to new and existing species

Possible Drawbacks

If applicable, describe any possible undesirable consequence of the changes. It is a fragile mapping, so extra spaces or special characters will probably break this.

Testing

Have you added/modified unit tests to test the changes? The parser was run on the same file before and after code changes.

If so, do the tests pass/fail? No data is parsed with the current code, data is parsed with the bugfix.

Have you run the entire test suite and no regression was detected?

Merge request reports