Skip to content

create_release_tasks.pl: explicitly dereference arguments to 'keys'

Marek Szuba requested to merge create_release_tasks-scalar_keys into master

Created by: mkszuba

Description

Make sure all calls to keys() in misc-scripts/jira/create_release_tasks.pl are passed hashes and not scalar hashrefs.

Use case

Being able to pass a scalar to each, keys, push, pop, shift, splice, unshift, and values was an experimental feature that was added in Perl 5.14 and since declared failed, thus causing the script to fail with an "Experimental keys on scalar is now forbidden" error.

Benefits

create_release_tasks.pl can now run under Perl 5.24 and newer.

Possible Drawbacks

None, other than the script being a few bytes (!) longer now.

Testing

Have you added/modified unit tests to test the changes?

n/a

If so, do the tests pass/fail?

n/a

Have you run the entire test suite and no regression was detected?

n/a, I have however tested the script by using it to create e! 95 core release tickets and it has worked fine.

Merge request reports