Skip to content

Bugfix/delint DBASS parser

Marek Szuba requested to merge bugfix/delint_DBASSParser into feature/xref_sprint

Created by: mkszuba

Description

Fixes bugs observed (so far) in DBASSParser during the xref sprint, add additional checks, and delint the code to facilitate further refactoring. See ENSCORESW-2886.

Use case

Part of the efforts to improve the xref pipeline. Moreover, one of the observed bugs actually prevents current versions of DBASS3 data from being fully parsed.

Benefits

DBASS3 input can now be parsed properly. Some future-proofing. Code (hopefully) easier to maintain. Passes PerlCritic inspection at level 3 and the only complaints at level 2 are missing certain POD sections and $VERSION. Use a standardised rather than hand-rolled CSV parser, with potential for a performance increase if compiled rather than native-Perl version of the parser is used.

Possible Drawbacks

None I can think of.

Testing

Have you added/modified unit tests to test the changes? No.

If so, do the tests pass/fail? N/A

Have you run the entire test suite and no regression was detected? N/A. However, I have run the parser itself on both current DBASS data and some intentionally malformed input, and it appears to work correctly.

Merge request reports