Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl
  • Merge requests
  • !315

Xref parser mgiparser

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marek Szuba requested to merge xref_parser_mgiparser into feature/xref_sprint Oct 22, 2018
  • Overview 7
  • Commits 7
  • Pipelines 0
  • Changes 1

Created by: premanand17

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Description

Updates:

Used Text:CSV for parsing the file Removed loading for mgi description from xref table Updated to get the description from the same file being read (MRK_ENSEMBL.rpt)

Use case

XrefParser for source MGI (MGI_official) for mouse (mus musculus)

Benefits

Code quality improvements, removed dependency on previous loaded mgi description from xref table

Possible Drawbacks

None

Testing

No until test. However, have tested it by running the xref_parser script and checked the _xref database for row counts.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: xref_parser_mgiparser