Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl
  • Merge requests
  • !318

Standardise table.sql file

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marek Szuba requested to merge github/fork/james-monkeyshines/master into master Oct 24, 2018
  • Overview 7
  • Commits 6
  • Pipelines 0
  • Changes 1

Created by: james-monkeyshines

Description and Use case

The new datacheck for validating a db schema uses the table.sql file. This is mostly consistent already, both within the file and between instances of the files in different repositories. But there are a few simple changes to terminology and formatting that would further standardise the files. These sorts of things can be handled in the datacheck code, but having fewer, and less complicated, exceptions makes the code more robust and easier to understand.

Benefits

Datacheck is simpler. Standardisation and consistency are generally good things to aim for.

Possible Drawbacks

None I can think of.

Testing

Unit tests not relevant. I created databases before and after the changes, and the results were identical.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/james-monkeyshines/master