Skip to content

Bugfix/xref parser tests

Marek Szuba requested to merge bugfix/xref_parser_tests into feature/xref_sprint

Created by: mkszuba

Description

Two bugs have been discovered in xref_parser.t in the course of testing the new UniProtParser, which is more strict regarding its input than the old version.

Use case

For the new UniProtParser, xref_parser.t (now a part of the Ensembl Core test suite and is executed by Travis) as it is fails due to:

  • using a nonexistent species ID in UniProtKB records it uses, and
  • inserting malformed cross-reference lines into said records.

For the old parser the latter is of no consequence due to more loose parsing of UniProtKB input, whereas the former causes offending entries to be quietly skipped.

Benefits

Makes xref_parser.t compatible with the new UniProtParser, and hopefully somewhat increases test coverage of the old one.

Possible Drawbacks

None I can think of.

Testing

Have you added/modified unit tests to test the changes? Yes

If so, do the tests pass/fail? Yes

Have you run the entire test suite and no regression was detected? N/A - the only thing that has changed is a single test file.

Merge request reports