Skip to content

Improve symmetry of store / remove in CoordSystemAdaptor

Marek Szuba requested to merge github/fork/kiwiroy/csa-remove-seqlevel into master

Created by: kiwiroy

Description

The internal caches are not accurately maintained for the CoordSystemAdaptor when calling $csa->remove($cs). This is especially a problem for default and sequence level coordinate systems.

Use case

$cs = $csa->fetch_sequence_level();
$csa->remove($cs);
$cs->name('fix typo');
$csa->store($cs);

Benefits

Completeness, symmetry.

Possible Drawbacks

Unsure.

Testing

New test for $csa->remove($cs) and side effects included which all pass. No regressions detected.

Merge request reports