Update PerlCritic and PerlTidy configuration
Created by: mkszuba
Description
Rename perlcriticrc to .perlcriticrc and perltidyrc to .perltidyrc, and replace the former with the version from ensembl-xref.
Use case
- When the aforementioned files are not dot-files they are not automatically picked up by respective tools, even when they are invoked within ensembl/;
- .perlcriticrc from ensembl-xref is more in like with internal Core-team Perl coding standards as agreed in December 2018.
Benefits
Easier invocation of perlcritic and perltidy. Fewer false positives from the former.
Possible Drawbacks
Running perlcritic manually without specifying severity will now make it very grumpy.
Testing
Have you added/modified unit tests to test the changes?
Yes, housekeeping_perlCritic.t has had the name of perlcriticrc updated.
If so, do the tests pass/fail?
They pass.
Have you run the entire test suite and no regression was detected?
Yes (with author tests enabled), no regression detected.