Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl
  • Merge requests
  • !420

Deprecate Bio::EnsEMBL::DBSQL::GenomeContainer::get_total_length()

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marek Szuba requested to merge feature/deprecate_basepair_count into master Sep 11, 2019
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: mkszuba

Description

Deprecate Bio::EnsEMBL::DBSQL::GenomeContainer::get_total_length()

Use case

Part of ENSINT-283. Web should stop using it already in e99 but let us play it safely on our end and follow the standard deprecation procedure.

Benefits

The first step towards removing a method known to provide incorrect information for certain species.

Possible Drawbacks

Test coverage will drop slightly (but will of course improve again once get_total_length() has been removed).

Testing

Have you added/modified unit tests to test the changes?

Yes, removed the test of get_total_length() from genomeContainer.t

If so, do the tests pass/fail?

They pass.

Have you run the entire test suite and no regression was detected?

Yes, no regression detected.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/deprecate_basepair_count