Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl
  • Merge requests
  • !468

JSON-formatted web_data

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marek Szuba requested to merge github/fork/james-monkeyshines/master into master Jan 14, 2020
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 6

Created by: james-monkeyshines

Changes have already been approved and merged on release/100 branch (https://github.com/Ensembl/ensembl/pull/467), this replicates them on master.

Description

Storing web_data as a flattened Perl hash is cumbersome, and, as it turns out, unnecessary - it's required by the webcode, but it is converted into JSON for processing. So we can make everone's lives easier by storing it as JSON in the first place. (cf. https://www.ebi.ac.uk/panda/jira/browse/ENSINT-396)

Use case

The main use case is for the webcode to retrieve the web_data in order to determine how to display a track. Setting the web_data field via the API is uncommon, but might occasionally be necessary.

Benefits

The web_data field no longer needs special treatment, it's just a JSON string that is set/got like any other text field.

Possible Drawbacks

Changing this requires tight integration with webcode changes. Those have been made (https://www.ebi.ac.uk/panda/jira/browse/ENSWEB-5249), and the plan is to get a sandbox running ASAP for testing the web display.

Testing

Have you added/modified unit tests to test the changes? Yes, analysis.t updated.

If so, do the tests pass/fail? Pass

Have you run the entire test suite and no regression was detected? Yes, all fine.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/james-monkeyshines/master