Skip to content

ENSCORESW-3503: keep analysis id when storing coordinate xrefs

Marek Szuba requested to merge bugfix/coordinate_analysis into master

Created by: magaliruffier


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing


Using one or more sentences, describe in detail the proposed changes. Entries in the object_xref table for coordinate xrefs are being stored with an analysis_id 0 The corresponding analysis is created but not used The proposed change passes the analysis_id for the correct analysis as an argument, to be stored in the object_xref table

Use case

Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place. analysis_id 0 is not really good No analysis_id would already be better, but as the analysis object already exist, might as well use it here


If applicable, describe the advantages the changes will have. No entry in object_xref with analysis_id 0

Possible Drawbacks

If applicable, describe any possible undesirable consequence of the changes. None that I can see


Have you added/modified unit tests to test the changes? NA

If so, do the tests pass/fail? NA

Have you run the entire test suite and no regression was detected? This part of the code has no test cases associated to it. The whole xref pipeline was run before and after the change to verify the change works as expected In particular, the datachecks run at the end of the pipeline were reporting those entries with analysis_id 0 and do not with the change

Merge request reports