Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl
  • Merge requests
  • !503

Closed
Created Aug 13, 2020 by Marek Szuba@mks
  • Report abuse
Report abuse

ENSCORESW-3349 changes made loops in parser for better performance.

  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

Created by: ameya1981

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Description

Optimize loops in RefSeqCoordinateParser which runs for human xrefs. No change in output is expected.

Use case

Potential memory issues caused by holding objects in memory

Benefits

Lesser memory required for parsing

Possible Drawbacks

NA

Testing

There is no unit test for this parser. Running the parser as a singlejob did not result into any memory failures(over multiple times). The xref count from these changes is same as the xref count from e100 parser

If so, do the tests pass/fail?

NA

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: optimize/RefSeqCoordinateParser